@jeisenbe, can you test this and tell me what you think the problem with name rendering might be?

Well, I was thinking that since pitches already have text rendering with text-dy and sport is piggy backing off of it, that sport would inherit its name rendering rules. I guess I'll have to create a new line of code for every sport in the text rendering section instead though. Thanks for looking at it.

You can combine all the sports under one feature.

Instead of this:

 [feature = 'leisure_pitch'][sport = 'american_football'][zoom >= 17] {
    marker-file: url('symbols/sport/american_football.svg');
    marker-fill: @leisure-green;
    marker-placement: interior;
    marker-clip: false;
  }

  [feature = 'leisure_pitch'][sport = 'archery'][zoom >= 17] {
    marker-file: url('symbols/sport/archery.svg');
    marker-fill: @leisure-green;
    marker-placement: interior;
    marker-clip: false;
  } 
etc...

Try this

  [feature = 'leisure_pitch'][zoom >= 17] {
    marker-fill: @leisure-green;
    marker-placement: interior;
    marker-clip: false;
    [sport = 'american_football'] { marker-file: url('symbols/sport/generic-sport.svg'); }  \\ add generic sport icon
    [sport = 'archery'] { marker-file: url('symbols/sport/archery.svg'); }
... etc.
    [sport = 'soccer'] { marker-file: url('symbols/sport/soccer.svg'); }
... etc.
  }

You can use the same idea for the text, if you don't use a generic sport icon:

      [feature = 'leisure_pitch'] {
        text-fill: darken(@pitch, 40%);
        [sport = 'american_football'],
        [sport = 'archery'],
... etc.
        [sport = 'soccer']  {
          text-dy: 10;
        }
      }

I'm thinking how would it match with planned green dots for sports centres (currently they have different rendering of nodes and different of areas). At the other hand, if we will agree about green icons for some sport centres, the same green icons for pitches would be a bad idea then. @Adamant36 What is your vision here?

@kocio-pl, would it be possible to move sports related things into their own sports.mss file? It would make it a lot easier to organize and implement this stuff. Especially with the other icons that are going to be added after this, adding icons to sports centers, issues for toboggans, golf stuff, pitch outlines etc. Otherwise its going to get pretty convoluted. The German style has one and the amenity points file is already pretty long in the tooth as it is.

@Tomasz-W, good question. I'll have to think about it. Both pitches and sports centers are leisure tags. So is there a reason they can't both be green?

I guess unifying sports center rendering would be good.

The problem with using a different color besides leisure green for the icons on pitches is that their names currently render in green. So the color on pitches without the sport tag would have to be modified. Otherwise, it wouldn't be consistent. There's also other sports tags that don't use pitches and are tagged on buildings like billiards. If we used a vastly different color for those it might be confusing. Plus, there's other things like name rendering on tracks mapped as lines. Since green is already being used on all those things and its established I don't see what the issue with using it on icons also would be. Otherwise, its going to have to be changed for everything else to. It could at least be lightened up a little if nothing else.

We could always forgo the fact that its all connected to a leisure tag though and create a different "sports" color category for names and icons related to sports. Like pure white or light blue or something. Id be fine with that to. As long as its consistent. Maybe it could be a different color for sports centers versus pitches though, but I'm not really sure what the difference is.

would it be possible to move sports related things into their own sports.mss file?

I guess it is preferable, since it is only concatenated just before compiling and should not add any speed penalty, while making things more clear (which is quite different from data layers).

We could also probably try to separate shops into shops.mss to make amenity-points.mss easier to manage.

And no matter what color we would use for sport, it makes sense to create color variable with that name. In the simplest case this will be just the same color as leisure.

Sweet. Shops was the other one I've been seriously considering doing it with.

I'll probably move everything into its own file before this is finalized. It seems like it will take a while to get the color thing figured out anyway.

Just make sure to create separate PRs, since any relocations are error prone and much harder to check than adding or removing code.

The green icons match well with the green color of pitches, and with the green name labels.

But I agree it looks a little unusual when a building is covering the pitch, and the sport icon now shows on the building, while the pitch area is not visible, eg:

Perhaps @Adamant36 could add [is_building = 'no']? This could prevent some of the cases where the sport icon is rendering in a building. eg

[feature = 'leisure_pitch'][is_building = 'no'][zoom >= 17] { marker-fill: @leisure-green; ... etc.

That might be a good idea. I was kind of wondering if rendering icons for stuff inside buildings like that is even necessary. I wouldn't consider the inside of a building a pitch and it seems like a little excessive. There's no reason instances like that can't be tagged with sports center or something instead and have the sport tag added to it that way.

I think is_building goes in the project file though doesn't it? or can it go anywhere?

For detecting pitches inside the buildings indoor=* namespace would be useful, but that might need some discussion and documentation changes.

I propose to go with leisure-green icons, and then take care of sport centres. If further test renderings will show that both leisure-green pitches icons and sport centres icons would cause mess, we would change pitches icons to man-made-grey.

Btw. I'm not a coder so I might be wrong, but I'm worried that there could be a problem of #3284 with icons for sports centres areas. If I understand it correctly, we can add icons only for sports centres nodes, am I right?

Not that I disagree per say, but there are things out there with only node rendering that are also mapped as areas.

I think the current code is mergable, both nodes and areas with green icons are OK for me. If you want to design some more changes to the rendering of pitches and sport centers, please open new tickets for that.

Sweet. I was actually going to ask if you could merge it as is and we can workout the other stuff in a new issue later. There's much going on right now to get hung up on one thing.

I think they should be rendered from z18. z17 is quite general high zoom level, it's not suitable for such details.

@kocio-pl, your probably right. I updated it.

Thanks.

It looks like there is a problem with labels - I started with american football and found that when we have the icon now, the label does not show at all. This is true also in your own example:

https://www.openstreetmap.org/way/174272803

Oh yeah, thanks for bringing that up again. I totally forgot about it.

The thing I don't get is that pitches already have their name displayed. So I don't know why the icons wouldn't piggyback off of that. Especially since the names still rendered at levels above the icon displaying and its further down in the code.

When I tried adding the sport features to the text part it didn't do anything. So can you do me a favor and test your solution to see if it actually works? Then copy the code here so I can paste it into the file since I couldn't get it to work myself? Otherwise, maybe it would be worth merging as is and then someone can start a new issue about it. Or we can wait forever for me to figure it out on my own.

When it comes to icons:

• I propose to flip runner icon so it's more distinct from fitness station
• basketball icon is too strong and it could be made lighter by making white rectangle inside wider (probably 2 px instead of 1 px)

Ok. Tomasz-W, you want to do that?

The handle of the paddle for the tennis table is also too long in proportion.

Sorry guys, as I have a lot of more important things on my head now (university stuff, organising charity action, family meetings...), I can't promise when I'll provide fixed icons and icons for more sports. Meanwhile, please discuss about wanted sport=* tags with dedicated icon and make a clear tasklist for me, it would be easier to understand what I have to do.

Since @Tomasz-W has no time and @Adamant36 wants to merge this soon, I make proposals for the 2 missing icons that @kocio-pl asked for above:

• running.svg flipped version of @Tomasz-W 's icon, unfortunately very similar to sports shop icon
• basketball.svg basketball icon made lighter by making white rectangle inside wider (2 px) (or use @Tomasz-W's ball icon)

Probably not perfect but can perhaps be improved later when more icons are added.

@Hufkratzer, thanks for the updated icons. I'll test them as soon as I get the time.

New running and basketball icons in the same place as the original running icon test rendering here. They fine to me. If they are good I'll update the commit so it can be further tested and merged.

@Hufkratzer Thanks for working on these icons, but you have to remember about our standards:

• if you want to cut some part of icon, draw a solid-white shape on it, then select both black and white parts and then click Path -> Difference (you used shape transparency option there, but this white shapein the middle should be just cutted out of bigger black shape)
• after cutting select all elements and click Path -> Union (they should be one part)
• save file in "Clean SVG" format (2nd one on the "Save as" list)
• if code of your icon would be still much longer than e.g. code here, you can use this icon file as a template file and copy designed icon there, it should be shorter then

Thanks @Tomasz-W. Guess I'll retest them after they get fixed. Sigh.

@Tomasz-W
Sorry, I don't understand, please explain again what is wrong:

• My running.svg is just a flipped version of your running.svg, I opend yours, flipped it and saved it as a normal svg; it is not longer than yours. What else is missing?
• My basketball.svg is a single path (built with difference and union) and then I have pasted this into the background of some other icon as you recommended here, is not longer than this basketball.svg. I am not sure if the white canvas is needed when the icon itself is 14x14 already, I can take it out, but some other icons (e.g. toys.svg, playgroind.svg, beach_resort.svg) have it too. I don't undestand what else could be wrong.

@Adamant36
Please check if you have tested the latest version of my basketball icon, I edited it 2 times yesterday.

I tested whatever icon was in the link four hours ago. There was only one.

Then you tested the currently latest revision.

But does it make sense to render pitch + running with an icon at all? Isn't that mistagging and running only to be used with track? Compare https://wiki.openstreetmap.org/wiki/Tag:sport=running.

Hhmmm, I dont know. Its a good question. The says a pitch is "An area designed for playing a particular sport, normally designated with appropriate markings." it seems like running tracks fit that and its not mentioned as misstagging on the track page. There's a thousandish instances of sport=running. So...Personally, id think they could co exist. Since a track is a type of pitch, but maybe it needs disscussion somewhere (tagging mailing list?).

Im impartial since I dont particularly like having an icon for tracks anyway. Since its pretty obvious thats what they are and it seems like the position of the icon is random.

I would like to see this done at some point though. My current VM and Docker setup is semi screwed up (plus, I dont like Ubuntu version im using anyway) and I need to reinstall everything to get it back to normal again..

@dieterdreist, I'm fine removing it then. I guess the only other thing is figuring out the problem with the basketball icon if there is one.

I also think that running tracks/pitches might be best left without any icon, it's pretty clear from the shape (horse running should have different context and maybe icon too) and they are smaller, so it would be a bit too much.

Problems happen especially with running polygons in stadiums. Icon should be located on the middle and then overlaps the pitch in the centre of the stadium.

@Tomasz-W, when you get some time would you mind fixing the basketball icon since your the one that seems to know all this stuff?

Sure, I think I'll do it within next week.

@Tomasz-W, any update on the icon?

@matthijsmelissen, are you going to reject this for being to detailed/extra icons/whatever when it comes time? (I don't mind if you do, I just thought id ask since I noticed your issue about icons and it might qualify as over detailed, maybe?).

@Adamant36 Updated and reviewed icons:

• https://gist.github.com/Hufkratzer/f8eff06061072894da5a8429c245763d
• https://gist.github.com/Hufkratzer/567085eb8331cc96b241bac650e0c6e2

@Adamant36 I think I'm going to postpone making a decision on this PR (either way) until after the discussion has finished (hopefully not too long).

Personally, I think for the sake of fairness to the people that work into this over the last few years (not just me, and the fact that it had four years worth of being open for a maintainer to close it if they wanted, it shouldnt be considered in connection to the current disscussion about not adding new features and should judged on its own merrets (Surely map clutter cant be a valid reason to add it as there's no other icons in the middle of sports pitches that they would colude with).

Just wanted to say thanks for the work in this PR, the icons look good and I think they will be a welcome addition to the map.

Your welcome. Im just waiting for them to get the meta issue dealing with adding new icons or not figured out. Then I'll update it so it can be reviewed and merge. I might update it soon either way though.